Custom insert map#546
Custom insert map#546keshav234156 wants to merge 9 commits intopubliclab:mainfrom keshav234156:CustomInsertMap
Conversation
Co-authored-by: Cess <cessmbuguar@gmail.com>
adds .vscode in .gitignore adds _SpecRunner.html in .gitignore Co-authored-by: Emily Ashley <15912063+emilyashley@users.noreply.github.com> Co-authored-by: Govind Goel <52847415+govindgoel@users.noreply.github.com> Co-authored-by: Cess <cessmbuguar@gmail.com>
|
@jywarren Please review!! |
|
@NitinBhasneria @Shreyaa-s @Shulammite-Aso Please review!! |
|
Hi @keshav234156! Also wanted to note that now that we have UI tests in Jes (#541) maybe you could add a simple test to demonstrate this? As well as a screenshot? Thank you so much! |
…into CustomInsertMap
|
@jywarren Added the test!! |
|
@Shreyaa-s @Shulammite-Aso @NitinBhasneria Please review!! |
| $('.wk-commands').append('<a class="woofmark-command-insert-map btn btn-default" data-toggle="Insert" title="Custom Insert Maps"><i class="fa fa-globe"></i></a>'); | ||
|
|
||
| var builder = '<div class="input-group">'; | ||
| builder += '<input type="number" class="form-control" placeholder="Latitude" id="Latitude" style="min-width: 150px;" required>'; |
There was a problem hiding this comment.
Hi! I have some similar questions to this comment about the classnames and ids here. What do you think?
| }); | ||
|
|
||
| describe('Custom Insert Map', () => { | ||
| test('Add Custom Insert Map in rich text mode', async () => { |
There was a problem hiding this comment.
I'd also love to incorporate any feedback people offer on this comment in this PR as well. Does that sound all right? Thanks!!
|
|
|
Hi @keshav234156 i hope you're doing well. I was wondering if you're available at all to try to wrap this up? No pressure, it'd just be nice to see merged! Thanks again for your work!!! |
|
@jywarren can we just postpone it for another 1 week. Will surely do it after that. |
|
No problem or rush at all, @keshav234156 -- much appreciated. |
|
Hi @keshav234156 did you have any availability to wrap this up as it's almost there? If not, we can try to find someone else to pitch in, thank you!!!! |
4 participants
Concerns #419
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt jasminefixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!